TST: Replace 'ensure_clean' with 'temp_file' in some tests #62474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kianelbo
force-pushed
the
tempfile-replace
branch
from
1fad1b4 to
1ee1b13
Compare
Contributor
Author
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
mroeschke
requested changes
Oct 7, 2025
| with parser.read_csv(path, chunksize=20) as result: | ||
| for _ in result: | ||
| pass | ||
| path = str(temp_file) |
Member
There was a problem hiding this comment.
Can you just use temp_file directly, instead of converting to a str? (Unless the test appears to explicitly testing a string path)
mroeschke
approved these changes
Oct 7, 2025
Member
|
Thanks @kianelbo |
jzwick
pushed a commit
to jzwick/pandas
that referenced
this pull request
Oct 8, 2025
…v#62474) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
eicchen
pushed a commit
to eicchen/pandas
that referenced
this pull request
Oct 18, 2025
…v#62474) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
mittal-aakriti
pushed a commit
to mittal-aakriti/pandas
that referenced
this pull request
Nov 19, 2025
…v#62474) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
mittal-aakriti
pushed a commit
to mittal-aakriti/pandas
that referenced
this pull request
Nov 19, 2025
…v#62474) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ensure_cleanutility function with thetemp_filepytest fixture #62435